gitgabrio commented on code in PR #5647:
URL:
https://github.com/apache/incubator-kie-drools/pull/5647#discussion_r1449058619
##########
drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/BaseKnowledgeBuilderResultImpl.java:
##########
@@ -32,8 +32,10 @@
public abstract class BaseKnowledgeBuilderResultImpl implements
KnowledgeBuilderResult {
private Resource resource;
+ private String message;
- protected BaseKnowledgeBuilderResultImpl(Resource resource) {
+ protected BaseKnowledgeBuilderResultImpl(Resource resource, String
message) {
+ this.message = message != null ? message : "";
Review Comment:
With @mariofusco we tried to be a little bit "conservative": put a stronger
enforce here - e.g. with thrown exception - could have a bigger/worst impact.
As a matter of fact, all downstream builds failed, and I have to check if
this modification broke something elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
