jomarko commented on issue #424:
URL: 
https://github.com/apache/incubator-kie-issues/issues/424#issuecomment-1889437805

   Hello team, I just wonder what are the 'acceptance criteria' here.
   
   - what should be the cli command name? should it be `form-generation-tool`? 
or should the name somehow reflect `apache`, or `kie` ?
   - am I correct user will be intended to firstly execute `npm install -g 
@kie-tools/form-generation-tool` to make this new cli command available on 
his/her machine?
   
   
   I was able to prepare a `packages/form-generation-tool/src/cli/cli.js` file:
   ```
   #! /usr/bin/env node
   /* License omitted */
   require("../../dist/index");
   ```
   
   then I prepared update in `packages/form-generation-tool/package.json`:
   ```
     "bin": {
       "form-generation-tool": "./src/cli/cli.js"
     },
   ```
   and was able to execute it as `npm run form-generation-tool`  from the 
`packages/form-generation-tool` folder
   
   
   However I somehow feel, this is not enough verification before some `npm 
publish` is done.
   
   
   Could somebody help me with better understanding acceptance criteria? How to 
be sure prepared changes are expected?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to