gitgabrio commented on code in PR #5650:
URL:
https://github.com/apache/incubator-kie-drools/pull/5650#discussion_r1450711023
##########
pom.xml:
##########
@@ -140,6 +140,25 @@
</mailingList>
</mailingLists>
+ <properties>
+
<project.build.outputTimestamp>2024-01-12T00:00:00Z</project.build.outputTimestamp>
+ </properties>
+
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-artifact-plugin</artifactId>
+ <version>3.3.0</version>
Review Comment:
could you please move that 3.3.0 version inside the `<properties>` tag, and
also pick the most recent one ?
Generally speaking, we try to define actual version as property, to allow
easier modification (if needed)
##########
pom.xml:
##########
@@ -140,6 +140,25 @@
</mailingList>
</mailingLists>
+ <properties>
+
<project.build.outputTimestamp>2024-01-12T00:00:00Z</project.build.outputTimestamp>
Review Comment:
Out of curiosity: is this fixed/hardcoded timestamp something that we have
to modify, in future, maybe with some dinamc value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
