mariofusco commented on code in PR #5649: URL: https://github.com/apache/incubator-kie-drools/pull/5649#discussion_r1452102359
########## drools-core/src/main/java/org/drools/core/common/SuperCacheFixer.java: ########## @@ -0,0 +1,270 @@ +package org.drools.core.common; + +import org.drools.base.common.NetworkNode; +import org.drools.base.reteoo.NodeTypeEnums; +import org.drools.core.reteoo.AccumulateNode; +import org.drools.core.reteoo.AlphaNode; +import org.drools.core.reteoo.AlphaTerminalNode; +import org.drools.core.reteoo.AsyncReceiveNode; +import org.drools.core.reteoo.AsyncSendNode; +import org.drools.core.reteoo.ConditionalBranchNode; +import org.drools.core.reteoo.EvalConditionNode; +import org.drools.core.reteoo.ExistsNode; +import org.drools.core.reteoo.FromNode; +import org.drools.core.reteoo.JoinNode; +import org.drools.core.reteoo.LeftInputAdapterNode; +import org.drools.core.reteoo.LeftTupleNode; +import org.drools.core.reteoo.LeftTupleSinkNode; +import org.drools.core.reteoo.LeftTupleSource; +import org.drools.core.reteoo.NotNode; +import org.drools.core.reteoo.ObjectSource; +import org.drools.core.reteoo.ObjectTypeNode; +import org.drools.core.reteoo.ObjectTypeNodeId; +import org.drools.core.reteoo.QueryElementNode; +import org.drools.core.reteoo.QueryTerminalNode; +import org.drools.core.reteoo.ReactiveFromNode; +import org.drools.core.reteoo.RightInputAdapterNode; +import org.drools.core.reteoo.RightTuple; +import org.drools.core.reteoo.RightTupleSink; +import org.drools.core.reteoo.RuleTerminalNode; +import org.drools.core.reteoo.Sink; +import org.drools.core.reteoo.TerminalNode; +import org.drools.core.reteoo.TimerNode; +import org.drools.core.reteoo.TupleImpl; +import org.drools.core.reteoo.WindowNode; + +// It's better to always cast to a concrete or abstract class to avoid +// secondary super cache problem. See https://issues.redhat.com/browse/DROOLS-7521 +public class SuperCacheFixer { + public static LeftTupleNode getLeftTupleNode(TupleImpl t) { + Sink s = t.getSink(); + switch (((BaseNode) s).getType()) { Review Comment: Unnecessary cast. ########## drools-core/src/main/java/org/drools/core/common/SuperCacheFixer.java: ########## @@ -0,0 +1,270 @@ +package org.drools.core.common; + +import org.drools.base.common.NetworkNode; +import org.drools.base.reteoo.NodeTypeEnums; +import org.drools.core.reteoo.AccumulateNode; +import org.drools.core.reteoo.AlphaNode; +import org.drools.core.reteoo.AlphaTerminalNode; +import org.drools.core.reteoo.AsyncReceiveNode; +import org.drools.core.reteoo.AsyncSendNode; +import org.drools.core.reteoo.ConditionalBranchNode; +import org.drools.core.reteoo.EvalConditionNode; +import org.drools.core.reteoo.ExistsNode; +import org.drools.core.reteoo.FromNode; +import org.drools.core.reteoo.JoinNode; +import org.drools.core.reteoo.LeftInputAdapterNode; +import org.drools.core.reteoo.LeftTupleNode; +import org.drools.core.reteoo.LeftTupleSinkNode; +import org.drools.core.reteoo.LeftTupleSource; +import org.drools.core.reteoo.NotNode; +import org.drools.core.reteoo.ObjectSource; +import org.drools.core.reteoo.ObjectTypeNode; +import org.drools.core.reteoo.ObjectTypeNodeId; +import org.drools.core.reteoo.QueryElementNode; +import org.drools.core.reteoo.QueryTerminalNode; +import org.drools.core.reteoo.ReactiveFromNode; +import org.drools.core.reteoo.RightInputAdapterNode; +import org.drools.core.reteoo.RightTuple; +import org.drools.core.reteoo.RightTupleSink; +import org.drools.core.reteoo.RuleTerminalNode; +import org.drools.core.reteoo.Sink; +import org.drools.core.reteoo.TerminalNode; +import org.drools.core.reteoo.TimerNode; +import org.drools.core.reteoo.TupleImpl; +import org.drools.core.reteoo.WindowNode; + +// It's better to always cast to a concrete or abstract class to avoid +// secondary super cache problem. See https://issues.redhat.com/browse/DROOLS-7521 +public class SuperCacheFixer { + public static LeftTupleNode getLeftTupleNode(TupleImpl t) { + Sink s = t.getSink(); + switch (((BaseNode) s).getType()) { + case NodeTypeEnums.RuleTerminalNode : return (RuleTerminalNode) s; + case NodeTypeEnums.QueryTerminalNode: return (QueryTerminalNode) s; + case NodeTypeEnums.RightInputAdapterNode: return (RightInputAdapterNode) s; + case NodeTypeEnums.LeftInputAdapterNode: return (LeftInputAdapterNode) s; + case NodeTypeEnums.AlphaTerminalNode: return (AlphaTerminalNode) s; + case NodeTypeEnums.AccumulateNode : return (AccumulateNode) s; + case NodeTypeEnums.ExistsNode: return (ExistsNode) s; + case NodeTypeEnums.NotNode: return (NotNode) s; + case NodeTypeEnums.FromNode: return (FromNode) s; + case NodeTypeEnums.JoinNode: return (JoinNode) s; + case NodeTypeEnums.EvalConditionNode: return (EvalConditionNode) s; + case NodeTypeEnums.AsyncReceiveNode: return (AsyncReceiveNode) s; + case NodeTypeEnums.AsyncSendNode: return (AsyncSendNode) s; + case NodeTypeEnums.ReactiveFromNode: return (ReactiveFromNode) s; + case NodeTypeEnums.ConditionalBranchNode: return (ConditionalBranchNode) s; + case NodeTypeEnums.QueryElementNode: return (QueryElementNode) s; + case NodeTypeEnums.TimerConditionNode: return (TimerNode) s; + case NodeTypeEnums.MockBetaNode: return (LeftTupleNode) s; + default: + throw new UnsupportedOperationException("Cannot be cast to LeftTupleNode: " + s); + } + } + + public static RightTupleSink getRightTupleSink(RightTuple t) { + Sink s = t.getSink(); + switch (((BaseNode) s).getType()) { Review Comment: Unnecessary cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
