yesamer commented on PR #2108: URL: https://github.com/apache/incubator-kie-tools/pull/2108#issuecomment-1893427679
@jomarko I applied the following change: <img width="823" alt="Screenshot 2024-01-16 at 10 51 03" src="https://github.com/apache/incubator-kie-tools/assets/16005046/71a23882-ae14-41b5-9aad-67e70a541986";> Here, I merged `ScenarioType` and `BackgroundDataType` types on a single new type FactMappingValuesTypes, considering they hold the data as you correctly spotted. Can't do the same for`scenariosType` & `backgroundDatasType` types: they hold the same data, but they are bound to different tag names, and that means I can't remove those `if` management. Does make sense? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
