RichardW98 commented on code in PR #350:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/350#discussion_r1455911128
##########
controllers/profiles/profile.go:
##########
@@ -71,6 +71,8 @@ type ReconciliationState interface {
Do(ctx context.Context, workflow *operatorapi.SonataFlow) (ctrl.Result,
[]client.Object, error)
// PostReconcile performs the actions to perform after the
reconciliation that are not mandatory
PostReconcile(ctx context.Context, workflow *operatorapi.SonataFlow)
error
+ // CanReconcileNext check if next state can be reconciled
+ CanReconcileNext() bool
Review Comment:
sorry I misunderstood your last review. this logic here indeed adds much
more complexity that we don't need as sonataflow opr. Users should be at their
own obligation for the reconcile of these objs too. I will remove the Knative
state and Knative status condition, and move the ensurer to the handlers 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
