fjtirado commented on code in PR #3358:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3358#discussion_r1456395076
##########
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/registry/ProcessDefinitionRegistration.java:
##########
@@ -37,9 +40,10 @@ public class ProcessDefinitionRegistration {
ProcessDefinitionEventRegistry processDefinitionRegistry;
@Inject
- public ProcessDefinitionRegistration(Application application,
KogitoRuntimeConfig runtimeConfig, Instance<Processes> processes) {
+ public ProcessDefinitionRegistration(Application application,
KogitoRuntimeConfig runtimeConfig, Instance<Processes> processes,
Instance<SourceFilesProvider> sourceFilesProvider) {
Review Comment:
We keep this optional, so source addon should still be present for source to
be added to the event.
The alternative is to make this mandatory and move
SourceFilesProviderFactory to quarkus common extension.
I wanted to be conservative since we are close to the release deadline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
