tiagobento commented on issue #151: URL: https://github.com/apache/incubator-kie-issues/issues/151#issuecomment-1896652921
@jomarko Great findings! Regarding the version of GitHub we should support, I think we should always try and go for "best effort @ latest". It's unrealistic that we'll be able to maintain retro-compatibility with older GitHub Enterprise Server (GHES) versions, especially because we don't have a way to automatically test it. IMHO, our benchmark should always be github.com. Users will then have the option to try and run the extension at their GHES instances, but it might not work. Regarding which of the two strategies is better for us, my opinion is that we should go with option 2, as users still have the option to fine-tune their permissions. One thing we must be careful about, is that if our extension is running in all websites, we should make sure it very quickly detects whether or not the current tab is indeed a GitHub page, so that we don't negatively impact the user's experience on websites other than GitHub tabs. With respect to the hard-coded `github.com` references, I think it's fair to say we should just change it to `location.origin`. I'm eager to hear other people's opinions too. Once again, well done @jomarko! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
