mariofusco opened a new issue, #5656:
URL: https://github.com/apache/incubator-kie-drools/issues/5656

   The `kogito-codegen-*` modules are all modules used internally for the code 
generation of the different features of kogito. They are not meant to be 
directly imported by end-users, but they are only support for other modules and 
then I don't see any valid reason to keep them out of the product. In 
particular the `kogito-codegen-rules` module acts a support for other codegens 
and can be typically used in conjunction with the `kogito-codegen-processes` 
one  (which is part of the product) as demonstrated by 
`kogito-codegen-processes-integration-tests`, so especially for this use case 
it seems unreasonable to keep it in the product while excluding the other.
   
   Those codegen modules are mostly used for the Quarkus extension and there we 
need to take a decision on which of those extensions we want to actually keep 
also in the product. At the moment the only productized extension is the 
serverless-workflow one. Moreover now all the features provided by the 
`kogito-quarkus-rules-extension` are also present in the Drools extension. In 
essence now the Kogito rules extension is a pure duplicate of the Drools one, 
so I don't see any reason to keep it. For all other extensions (processes. 
decisions, predictions) we can maybe re-evaluate if we want to keep the out of 
the product, but if so I believe it would be trivial to do this with the 
mechanism already implemented by @rgdoliveira for Drools.
   
   In essence my suggestion is the following:
   - Keep all the `kogito-codegen-*` modules also in the product since they are 
not exposed to end-users.
   - Delete the `kogito-quarkus-rules-extension` module since now it is only a 
duplicate of the Drools extension for Quarkus.
   - Exclude all the Quarkus extensions that we don't want in the product at 
midstream level using @rgdoliveira's scripts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to