thiagoelg commented on code in PR #2129: URL: https://github.com/apache/incubator-kie-tools/pull/2129#discussion_r1463849798
########## packages/dev-deployment-upload-service/dev/Containerfile.ddus-buildtime-install: ########## @@ -5,25 +5,31 @@ # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at -# +# # http://www.apache.org/licenses/LICENSE-2.0 -# +# # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations -# under the License. +# under the License. FROM registry.access.redhat.com/ubi9/ubi-minimal:9.3 +ARG DDUS_FILESERVER_IP="" + EXPOSE 8091 ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_EXTRACT_TO_DIR=/tmp/unzip-at ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_PORT=8091 ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=dev ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_ROOT_PATH="/" -COPY ../dist/linux/dev-deployment-upload-service /bin +RUN microdnf install -y tar gzip findutils + +RUN curl ${DDUS_FILESERVER_IP}:8090/apache/incubator-kie-tools/releases/download/0.0.0/getDevDeploymentUploadService.sh | sed 's/localhost:8090/${DDUS_FILESERVER_IP}:8090/; s/https:\/\/github.com/http:\/\/${DDUS_FILESERVER_IP}:8090/' | bash Review Comment: Thinking about it, it's not difficult to make the version respect the `buildEnv.root.version` env variable. Let me see if it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
