fjtirado commented on PR #1968: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1907868085
@porcelli We spent quite amount of time on avoiding code duplication for Oracle and Postgresql and we will have to spent again when in future community ask for oracle support (as they already did in the past, the oracle support, a lot of copy paste from postgres that was later refactor, was added by community folks on their spare time) . I do not really see the problem on just removing the driver and test and keep the source code that does not depend on the driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
