mariofusco commented on PR #3369: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3369#issuecomment-1907932931
I approved this PR not because I'm a fan of removing potentially useful features in this way, but because I didn't see any alternative if we want to move forward with the first Apache release. Thinking twice, if we understand correctly, what it is not compliant with Apache policies is the use of the Oracle driver, that however we only use for tests (and in all honesty is highly questionable if a dependency with test scope should be considered among our actual dependencies and block the release). If that's the case the other alternative would be to keep the addon as it is and just remove the test. It's true that in this way we will end up with an untested addon, but I would argue that keeping this feature untested would be better than totally removing it. And on the longer term we could move this test, and maybe other with similar problems, into another project (maybe back in `kiegroup`?) so it won't be under the Apache control, but still we will be notified if a future change will break the addon. @porcelli please let me know if the alternative that I'm suggesting makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
