wmedvede commented on code in PR #362:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/362#discussion_r1466047355
##########
controllers/profiles/common/object_creators.go:
##########
@@ -147,7 +147,6 @@ func defaultContainer(workflow *operatorapi.SonataFlow)
(*corev1.Container, erro
FailureThreshold: healthStartedFailureThreshold,
PeriodSeconds: healthStartedPeriodSeconds,
},
- ImagePullPolicy: corev1.PullAlways,
Review Comment:
When we are deploying workflows for managed builds, we don't use the
"latest" tag, so this is good.
But when we deploy workflows with images that has been built outside
SonataFlow we are not setting any ImagePullPolicy here. But, ¿should we analyze
the image that was produced externally? or this produced at a later point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
