jomarko commented on code in PR #2126:
URL:
https://github.com/apache/incubator-kie-tools/pull/2126#discussion_r1466051828
##########
packages/chrome-extension-pack-kogito-kie-editors/manifest.dev.json:
##########
@@ -7,8 +7,8 @@
{
"run_at": "document_idle",
"js": ["content_scripts/github.js"],
- "matches": ["https://*.github.com/*";],
- "all_frames": true
+ "matches": ["https://*/*";, "http://*/*";],
+ "all_frames": false
Review Comment:
`all_frames` as `false` helps us to not produce similar logs, in other words
do not try to inject 'Open in KIE Sandbox' button into nested frames, where we
do not need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
