gitgabrio commented on PR #5664: URL: https://github.com/apache/incubator-kie-drools/pull/5664#issuecomment-1912169743
Thanks @tarilabs, I'll create another different test to follow your suggestion! Il Ven 26 Gen 2024, 15:21 Matteo Mortari ***@***.***> ha scritto: > ***@***.**** commented on this pull request. > > Thank you for the update. The way I understand this PR as it stands right > now, make coercion only for results of entry in DMN boxed Context. > > To me, #5657 (comment) > <https://github.com/apache/incubator-kie-drools/pull/5657#issuecomment-1900502590> > always applies. > To me, you need B.1 on function invocation and B.2 on type check for > coercion on return. > > So, this PR in the way I understand does not cover for B.1, and for B.2 > covers only in a specific case out of all the boxed expressions. > > You might want to consider, as previously suggested, to break down task > into subtasks, if that helps with complexity. > > Hope this helps you and @baldimir <https://github.com/baldimir> make > evaluations on the best way to proceed on this one! > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-kie-drools/pull/5664#pullrequestreview-1845845871>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAF25CSNOGPFQOKDPSAZ6ITYQO3VFAVCNFSM6AAAAABCI6YRFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBVHA2DKOBXGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
