dmartinol commented on code in PR #367:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/367#discussion_r1467798089
##########
workflowproj/workflowproj.go:
##########
@@ -38,6 +38,8 @@ import (
operatorapi
"github.com/apache/incubator-kie-kogito-serverless-operator/api/v1alpha08"
)
+// TODO: should we delete this whole file? seems used only the the associated
test functions
Review Comment:
I was not aware of module this and I totally missed the `README`: now I
understand that this is the tool used in `gen-manifest` utility. So, even if
the functions in this file are not used in the operator, it must stay in the
repo.
The reason why I bumped into this module is that it is performing some
manipulation of the properties that now are no more needed: I will remove that
part and also the generation of the `managed-props` ConfigMap that, I assume,
will not be part of the `gen-manifest` output.
I will validate the manifests using the README, thanks for the pointer.
Please comment if you believe that the `gen-manifest` should not behave as I
wrote above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
