yurloc commented on code in PR #3059:
URL:
https://github.com/apache/incubator-kie-optaplanner/pull/3059#discussion_r1469452123
##########
optaplanner-quarkus-integration/optaplanner-quarkus/runtime/pom.xml:
##########
@@ -113,6 +113,52 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <!-- Remove comments from META-INF/quarkus-extension.properties -->
+ <!-- This is needed because the file generated by quarkus contains a
timestamp in a comment that makes the build not reproducible -->
+ <!-- This workaround can be removed when drools will be migrated to
quarkus release containing this fix
https://github.com/quarkusio/quarkus/pull/38365 -->
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.1</version>
Review Comment:
Reuse `${version.maven-exec-plugin}`.
##########
optaplanner-quarkus-integration/optaplanner-quarkus/runtime/pom.xml:
##########
@@ -113,6 +113,52 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <!-- Remove comments from META-INF/quarkus-extension.properties -->
+ <!-- This is needed because the file generated by quarkus contains a
timestamp in a comment that makes the build not reproducible -->
+ <!-- This workaround can be removed when drools will be migrated to
quarkus release containing this fix
https://github.com/quarkusio/quarkus/pull/38365 -->
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.1</version>
+ <executions>
+ <execution>
+ <id>Remove comments from quarkus-extension.properties</id>
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>java</goal>
+ </goals>
+ <configuration>
+ <mainClass>org.drools.util.RemoveCommentsMain</mainClass>
+ <arguments>
+
<argument>${project.basedir}/target/classes/META-INF/quarkus-extension.properties</argument>
+ </arguments>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
Review Comment:
Create multiple executions instead of defining the same plugin multiple
times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
