jordigilh commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1470432852
##########
api/v1alpha08/sonataflowplatform_types.go:
##########
@@ -46,6 +46,45 @@ type SonataFlowPlatformSpec struct {
// `sonataflow.org/profile: prod`
// +optional
Services ServicesPlatformSpec `json:"services,omitempty"`
+ // Persistence defines the platform persistence configuration. When
this field is set,
+ // the configuration is used as the persistence for platform services
and sonataflow instances
+ // that don't provide one of their own.
+ // +optional
+ Persistence *PlatformPersistenceSpec `json:"persistence,omitempty"`
Review Comment:
That was the initial idea, but I found 2 issues with that:
* `PersistencePostgreSql` contains a `JdbcUrl` field, which opens the door
for using a database outside the cluster, potentially a security risk. I also
don't think it's a good idea to allow the user to enter free text to configure
the database here as it's more prone to typos. Let me know if if's there are no
such concerns and I will change the code to use the `JdbcUrl` field.
* `PostgreSqlServiceOptions` contains the `databaseSchema`. Each workflow
should use its own schema, rather than share it, so to avoid problems that
might occur when two workflows interact with the database using the same
schema. Instead, the schema used is the name of the workflow itself, thus
avoiding any collision that might happen if they all share the same schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
