(incubator-kie-kogito-runtimes) branch 1.40.x updated: [incubator-kie-issues#814] Fix NPE on BaseKnowledgeBuilderResultImpl.hashCode() (#3346) (#3379)

[yamer]

This is an automated email from the ASF dual-hosted git repository.

yamer pushed a commit to branch 1.40.x
in repository 
https://gitbox.apache.org/repos/asf/incubator-kie-kogito-runtimes.git


The following commit(s) were added to refs/heads/1.40.x by this push:
     new 0762251529 [incubator-kie-issues#814] Fix NPE on 
BaseKnowledgeBuilderResultImpl.hashCode() (#3346) (#3379)
0762251529 is described below

commit 0762251529e37cc80eabb0be0e2a45856789f2b3
Author: Yeser Amer <ya...@redhat.com>
AuthorDate: Wed Jan 31 10:06:04 2024 +0100

    [incubator-kie-issues#814] Fix NPE on 
BaseKnowledgeBuilderResultImpl.hashCode() (#3346) (#3379)
    
    Co-authored-by: BAMOE CI <bamoe...@ibm.com>
    (cherry picked from commit 2b4563cbfd23fa4494a3e9b9492f74987e691660)
    
    Co-authored-by: Gabriele Cardosi <gabriele.card...@gmail.com>
---
 .../src/main/java/org/jbpm/assembler/DuplicateProcess.java     | 10 +---------
 .../src/main/java/org/jbpm/compiler/ProcessLoadError.java      | 10 +++-------
 .../main/java/org/kie/kogito/codegen/rules/QueryGenerator.java |  6 +-----
 3 files changed, 5 insertions(+), 21 deletions(-)

diff --git 
a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java 
b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java
index f8a37e4fc3..d6205beac9 100644
--- 
a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java
+++ 
b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java
@@ -40,16 +40,8 @@ public class DuplicateProcess extends 
ConfigurableSeverityResult {
     public static final String KEY = "duplicateProcess";
     private static final int[] line = new int[0];
 
-    private String processId;
-
     public DuplicateProcess(Process process, KnowledgeBuilderConfiguration 
config) {
-        super(process.getResource(), config);
-        processId = process.getId();
-    }
-
-    @Override
-    public String getMessage() {
-        return "Process with same id already exists: " + processId;
+        super(process.getResource(), config, "Process with same id already 
exists: " + process.getId());
     }
 
     @Override
diff --git 
a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java 
b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java
index 1e4e6d2400..260e64acdc 100644
--- 
a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java
+++ 
b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java
@@ -23,22 +23,18 @@ import org.kie.api.io.Resource;
  * This is used for reporting errors with loading a ruleflow.
  */
 public class ProcessLoadError extends DroolsError {
-
-    private String message;
-    private Exception exception;
     private static final int[] lines = new int[0];
 
     public ProcessLoadError(Resource resource, String message, Exception 
nested) {
-        super(resource);
-        this.message = message;
-        this.exception = nested;
+        super(resource, getSpecificMessage(message, nested));
     }
 
+    @Override
     public int[] getLines() {
         return this.lines;
     }
 
-    public String getMessage() {
+    private static String getSpecificMessage(String message, Exception 
exception) {
         if (exception != null) {
             return message + " : Exception " + exception.getClass() + " : " + 
exception.getMessage();
         } else {
diff --git 
a/kogito-codegen-modules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java
 
b/kogito-codegen-modules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java
index 07342950a4..1835a11cea 100644
--- 
a/kogito-codegen-modules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java
+++ 
b/kogito-codegen-modules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java
@@ -209,14 +209,10 @@ public class QueryGenerator implements RuleFileGenerator {
         private final QueryModel query;
 
         public NoBindingQuery(QueryModel query) {
+            super("Query " + query.getName() + " has no bound variable. At 
least one binding is required to determine the value returned by this query");
             this.query = query;
         }
 
-        @Override
-        public String getMessage() {
-            return "Query " + query.getName() + " has no bound variable. At 
least one binding is required to determine the value returned by this query";
-        }
-
         @Override
         public int[] getLines() {
             return ERROR_LINES;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org