kbowers-ibm commented on issue #130: URL: https://github.com/apache/incubator-kie-issues/issues/130#issuecomment-1918738400
As detailed above, the problem was two-fold: Problem 1) The kogito icon was being rendered multiple times when the back button was pressed. This was happening because GitHub caches DOM structures between changes of history. Solution 1) This has been addressed by adding a cleanup function in the utils.ts (which was already used elsewhere in the application to address this problem happening with other components). Problem 2) The kogito icon was being rendered, but was un-interactable. This was happening due to an error where we were trying to "insertAdjacentHtml" to elements that hadn't been rendered yet. Solution 2) Fixed by making the affected function async, and only attempt to render once the element was available. (Similar to the SingleEditorView.ts) During testing found 2 bugs: https://github.com/bamoe/private-bamoe-issues/issues/1410 https://github.com/bamoe/private-bamoe-issues/issues/1411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
