This is an automated email from the ASF dual-hosted git repository.
tiagobento pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new d88877986fb NO-ISSUE: Fix Windows `boxed-expression-component`
Storybook start script (#2139)
d88877986fb is described below
commit d88877986fb024989012acf166addc3a50000c11
Author: Luiz João Motta <[email protected]>
AuthorDate: Thu Feb 1 21:26:17 2024 -0300
NO-ISSUE: Fix Windows `boxed-expression-component` Storybook start script
(#2139)
---
packages/boxed-expression-component/package.json | 7 ++++++-
packages/storybook-base/src/bin.ts | 2 +-
pnpm-lock.yaml | 8 +++++++-
3 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/packages/boxed-expression-component/package.json
b/packages/boxed-expression-component/package.json
index 03e63d810d1..01ab93d9433 100644
--- a/packages/boxed-expression-component/package.json
+++ b/packages/boxed-expression-component/package.json
@@ -11,7 +11,10 @@
"copy:css": "copyfiles -u 1 \"src/**/*.{sass,scss,css}\" dist/",
"deploy": "gh-pages -d dist-dev",
"lint": "run-script-if --bool \"$(build-env linters.run)\" --then
\"kie-tools--eslint ./src\"",
- "start": "pnpm storybook-base --storybookArgs=\"dev -p $(build-env
boxedExpressionComponent.storybook.port) --no-open\"",
+ "powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted
-Command",
+ "start": "run-script-os",
+ "start:linux:darwin": "cross-env STORYBOOK_PORT=$(build-env
boxedExpressionComponent.storybook.port) pnpm storybook-base
--storybookArgs=\"dev --no-open\"",
+ "start:win32": "pnpm powershell \"cross-env STORYBOOK_PORT=$(build-env
boxedExpressionComponent.storybook.port) pnpm storybook-base
--storybookArgs='dev --no-open'",
"test": "run-script-if --ignore-errors \"$(build-env
tests.ignoreFailures)\" --bool \"$(build-env tests.run)\" --then \"jest
--silent --verbose --passWithNoTests\"",
"test:e2e": "run-script-if --ignore-errors \"$(build-env
endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\"
--then \"pnpm rimraf ./dist-e2e\" \"pnpm test:e2e:run\"",
"test:e2e:open": "pnpm exec playwright show-report dist-e2e-tests/reports",
@@ -63,12 +66,14 @@
"@types/uuid": "^8.3.0",
"copy-webpack-plugin": "^11.0.0",
"copyfiles": "^2.4.1",
+ "cross-env": "^7.0.3",
"file-loader": "^6.2.0",
"jest": "^26.6.3",
"jest-junit": "^14.0.0",
"jest-when": "^3.5.0",
"react-json-view": "^1.21.3",
"rimraf": "^3.0.2",
+ "run-script-os": "^1.1.6",
"storybook": "^7.3.2",
"ts-jest": "^26.5.6",
"typescript": "^4.6.2",
diff --git a/packages/storybook-base/src/bin.ts
b/packages/storybook-base/src/bin.ts
index 57a72862007..bf5a83f454f 100644
--- a/packages/storybook-base/src/bin.ts
+++ b/packages/storybook-base/src/bin.ts
@@ -30,7 +30,7 @@ if (argv.indexOf("--env") !== -1 &&
argv[argv.indexOf("--env") + 1] === "live")
process.env.STORYBOOK_BASE_WRAPPER_INTERNAL__liveReload = "true";
}
-const storybook = spawn(`storybook`, storybookArgs);
+const storybook = spawn(`storybook`, [...storybookArgs, "-p",
process.env.STORYBOOK_PORT ?? ""], { shell: true });
storybook.stdout.setEncoding("utf8");
storybook.stdout.on("data", (data) => {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index f2fa7b5bbe4..119a03261d6 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -876,6 +876,9 @@ importers:
copyfiles:
specifier: ^2.4.1
version: 2.4.1
+ cross-env:
+ specifier: ^7.0.3
+ version: 7.0.3
file-loader:
specifier: ^6.2.0
version: 6.2.0([email protected])
@@ -894,6 +897,9 @@ importers:
rimraf:
specifier: ^3.0.2
version: 3.0.2
+ run-script-os:
+ specifier: ^1.1.6
+ version: 1.1.6
storybook:
specifier: ^7.3.2
version: 7.4.6
@@ -45171,7 +45177,7 @@ packages:
"@webpack-cli/configtest": 1.2.0([email protected])([email protected])
"@webpack-cli/info": 1.5.0([email protected])
"@webpack-cli/serve": 1.7.0([email protected])
- colorette: 2.0.20
+ colorette: 2.0.16
commander: 7.2.0
cross-spawn: 7.0.3
fastest-levenshtein: 1.0.12
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
