wmedvede commented on PR #367: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/367#issuecomment-1924354696
> > @dmartinol @ricardozanini @domhanak some positive feedback for the record. > > > > * In the workflow deployment environment I can't see any property > > But maybe we can start moving things there in a follow-up PR. If I understood well, we should start to see there this kind of props > > quarkus.http.port = 8080 > > quarkus.http.host = 0.0.0.0 > > as env vars. > > > > But we can think about this in follow-up PR > > Thanks for deep investigation and testing. Wrt the deployment environment, we changed our initial design because this option doesn't work well with property names including "-", see this issue [smallrye-reactive-messaging: incompatibility with configuration through environment variables](https://github.com/quarkusio/quarkus/issues/30106). E.g., `mp.messaging.outgoing.kogito-job-service-job-request-events.connector` cannot be managed that way. > > If you aim to model as env variables only the properties not affected by that issue, this is an option but at the same time we should keep the managed properties file for all of the others, so we'd have 3 managed source of configuration values. ok, we can see this in a future step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
