elguardian commented on PR #1971: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1971#issuecomment-1932079180
Hi @fjtirado seems a bit weird to me. for instance https://github.com/apache/incubator-kie-kogito-apps/pull/1971/files#diff-8016b6b06d81d9d9ff10d4a7039e71a34112c57e6fc4dc437c4ee6054b2988e2R61-R67 but if you are using the jdbc (which is really jpa based with some overriding) you are working with anything that is compliant with the jpa implementation but requires that overriding (not the entire jdbc) so brifly * we have a jpa (common that is not meant to be used by anybody and that could really work without anything else just defining the proper data source and adding the driver).. in fact there is no producer in here. I would suggests maybe for jpa-common. * jdbc as a wrap of the jpa module plus overriding (the naming does not reflect what really is). I do think it is not really good name. I would say jpa-<flavor> being the flavor you are supporting. I can guarantee you that for pgsql big users will use bytea to avoid the vacuun utility (instead of oid or blobs...). so probably will have something like jpa-bytea or something like that. So keep in mind that better have this in mind now that start renaming things afterwards. I think the strucutre allows some extension (probably not my preferred way) but it complies the need of some databases so it is fine. The thing doing the split (between jpa common and jdbc) it is only confusing as jpa is not meant to use by anybody. I would suggest jpa-common jpa-std (standard if the blob are meant to be supported by everyone....) jpa-byte... (or whatever flavours we ship. the thing I thinks does not reflect is just calling jdbc because it seems we are using standard sql without the jpa middle man. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
