fjtirado commented on code in PR #3381: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3381#discussion_r1481765898
########## addons/common/persistence/jdbc/src/main/java/org/kie/kogito/persistence/jdbc/DatabaseType.java: ########## @@ -1,67 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.kie.kogito.persistence.jdbc; - -import java.sql.Connection; -import java.sql.DatabaseMetaData; -import java.sql.SQLException; - -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -public enum DatabaseType { - ANSI("ansi", "process_instances"), - ORACLE("Oracle", "PROCESS_INSTANCES"), - POSTGRES("PostgreSQL", "process_instances"); Review Comment: @porcelli The enum was basically useless (as shown in the last [commit](https://github.com/apache/incubator-kie-kogito-runtimes/pull/3381/commits/0305cf1b7f2f8e5fdc3f206de1b1ef54dfc81fbc#diff-3dad653acea99a3d188839daa30fbf4e3aff67d3798061a6abd9d4af7d7a3cc3R41), there are better ways to find out if we should use the correlation feature, which currently only works in postgres) ? Therefore, removing it is better than start a discussion (not related with the intent of the PR) over which names we should give to an enum that is not needed. Another reason I cannot proceed with your request change is that those values you are proposing are implementation dependendant. The only feature (in runtimes, and this enum is for runtime) that is using jsonb is the serverless workflow correlation and that will soon change when we retake implementation of this feature (that was interrupted one year ago), so it does not make sense at all to expose this soon to be reverted implementation detail into a public enum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
