jmreardon-yoppworks commented on PR #5672: URL: https://github.com/apache/incubator-kie-drools/pull/5672#issuecomment-1935845388
> > @gitgabrio , I'm fine using a singleton of the `UnsupportedOperationException`. I started with the null approach because singleton exceptions are a little obscure, but the singleton is safer if we have downstream dependencies to worry about. > > Thanks @jmreardon-yoppworks ! Please let us know if that approach would solve the performance issue I'll rerun my bench with it this weekend to verify. I would be shocked if it had a different profile from the null fix. The only expensive part was filling the trace and the singleton avoids that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
