ricardozanini commented on code in PR #536:
URL:
https://github.com/apache/incubator-kie-kogito-docs/pull/536#discussion_r1489761326
##########
serverlessworkflow/modules/ROOT/pages/getting-started/create-your-first-workflow-service-with-kn-cli-and-vscode.adoc:
##########
@@ -6,9 +6,9 @@ This guide showcases using the Knative Workflow CLI plugin and
Visual Studio cod
* xref:testing-and-troubleshooting/kn-plugin-workflow-overview.adoc[Knative
Workflow CLI] {kn_cli_version} is installed.
* Visual Studio Code with
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-extension-serverless-workflow-editor[Red
Hat Serverless Workflow Editor] is installed to edit your workflows.
-.Preparing your environment
+.Preparing your environment for local development with locally deployed
cluster instance
* Install https://docs.docker.com/engine/install/[Docker] or
https://podman.io/docs/installation[Podman].
-* Install https://minikube.sigs.k8s.io/docs/start/[minikube].
+* Install https://minikube.sigs.k8s.io/docs/start/[minikube] ( or Kind ).
Review Comment:
To add the kind link
##########
serverlessworkflow/modules/ROOT/pages/getting-started/create-your-first-workflow-service-with-kn-cli-and-vscode.adoc:
##########
@@ -17,7 +17,7 @@ minikube start --cpus 4 --memory 8096 --addons registry
--addons metrics-server
----
* (optional) Install https://k9scli.io/[k9scli.io]
* xref:cloud/operator/install-serverless-operator.adoc[]
-* Install https://github.com/kiegroup/kie-tools/releases/tag/0.30.3[KN
Workflow CLI] by downloading the correct distribution for your development
environment and adding it to the PATH.
+* Install https://github.com/kiegroup/kie-tools/releases/tag/0.32.0[SonataFlow
plug-in for Knative CLI]. Follow
xref:testing-and-troubleshooting/kn-plugin-workflow-overview.adoc[] guide.
Review Comment:
To move this version to a variable in the `antora.yaml`
##########
serverlessworkflow/modules/ROOT/pages/use-cases/advanced-developer-use-cases/getting-started/build-serverless-workflow-quarkus-examples.adoc:
##########
@@ -0,0 +1,64 @@
+= Building images of serverless workflow example applications using Quarkus CLI
Review Comment:
```suggestion
= Building images of SonataFlow example applications using Quarkus CLI
```
WDYT about using SonataFlow instead of serverless workflow? We can mention
_serverless workflow_ only in the context of the spec.
Alternatively, we can stick to _workflow service_ to avoid repeating
SonataFlow every where.
##########
serverlessworkflow/modules/ROOT/pages/use-cases/advanced-developer-use-cases/integrations/serverless-dashboard-with-runtime-data.adoc:
##########
@@ -254,7 +254,7 @@ For more information about creating a workflow, see
xref:getting-started/create-
The following is an example of GraphQL query that lists all the workflows:
.Example GraphQL query to retrieve all workflows
-[source,json]
+[source,grahpql]
Review Comment:
During the build have you seen any warns that this source type doesn't
exist? I guess I tried that and it wasn't supported at the time.
##########
serverlessworkflow/modules/ROOT/pages/persistence/core-concepts.adoc:
##########
@@ -0,0 +1,5 @@
+= Persistence in {product_name}
+
+TODO: desribe how the persistence is working in Sonataflow and its intention
+TODO: link to no code guide for operator managed persistence setup
+TODO: link to quarkus advanced guides for manual setup
Review Comment:
I think @wmedvede has a related task that we can link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
