gitgabrio commented on code in PR #5686:
URL:
https://github.com/apache/incubator-kie-drools/pull/5686#discussion_r1497912123
##########
kie-dmn/kie-dmn-model/src/main/java/org/kie/dmn/model/api/ItemDefinition.java:
##########
@@ -38,9 +38,15 @@ public interface ItemDefinition extends NamedElement {
void setAllowedValues(UnaryTests value);
- UnaryTests getTypeConstraint();
-
- void setTypeConstraint(UnaryTests value);
+ default UnaryTests getTypeConstraint() {
+ // Since DMN 1.5
+ return null;
Review Comment:
@yesamer Yes.
Actually, it is needed, otherwise all model < 1.5 would throw the exception
(that's why I replaced it).
We did not see that before, because before my PR the `getTypeConstraint` was
never invoked.
There is a huge usage of `null` inside DMN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
