tkobayas commented on code in PR #5730:
URL:
https://github.com/apache/incubator-kie-drools/pull/5730#discussion_r1498973169
##########
drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java:
##########
@@ -126,8 +126,10 @@ private void applyChildrenDescrs(PackageDescr
packageDescr, List<BaseDescr> desc
} else if (descr instanceof AttributeDescr) {
packageDescr.addAttribute((AttributeDescr) descr);
} else if (descr instanceof RuleDescr) { // QueryDescr extends
RuleDescr
- packageDescr.addRule((RuleDescr) descr);
- packageDescr.afterRuleAdded((RuleDescr) descr);
+ RuleDescr ruleDescr = (RuleDescr) descr;
+ packageDescr.addRule(ruleDescr);
+ packageDescr.afterRuleAdded(ruleDescr);
+ ruleDescr.setNamespace(packageDescr.getNamespace());
Review Comment:
Just setting a package name to `ruleDescr.namespace`. Without this, the
exec-model generated rules will be in `defaultpkg` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]