tiagobento commented on code in PR #2158:
URL:
https://github.com/apache/incubator-kie-tools/pull/2158#discussion_r1500893798
##########
packages/dmn-editor/stories/useCases/loanPreQualification/LoanPreQualification.mdx:
##########
@@ -0,0 +1,38 @@
+{/* prettier-ignore */}
+{/*
Review Comment:
? :D
##########
packages/dmn-editor/package.json:
##########
@@ -49,6 +53,7 @@
"elkjs": "^0.9.1",
"fast-deep-equal": "^3.1.3",
"immer": "^10.0.3",
+ "lodash": "^4.17.21",
Review Comment:
Shouldn't that be a `devDependency`? I mean, we're not using `lodash` in the
DmnEditor itself, but rather on test case.
##########
packages/dmn-editor/src/diagram/nodes/OutgoingStuffNodePanel.tsx:
##########
@@ -61,6 +61,55 @@ export function OutgoingStuffNodePanel(props: { isVisible:
boolean; nodeTypes: N
[props.isVisible]
);
+ const getEdgeActionTitle = React.useCallback((edgeType: string): string => {
+ switch (edgeType) {
+ case EDGE_TYPES.informationRequirement: {
+ return "Add Information Requirement edge";
+ }
+ case EDGE_TYPES.knowledgeRequirement: {
+ return "Add Knowledge Requirement edge";
+ }
+ case EDGE_TYPES.authorityRequirement: {
+ return "Add Authority Requirement edge";
+ }
+ case EDGE_TYPES.association: {
+ return "Add Association edge";
+ }
+ default: {
+ return "Add Unknon edge type";
+ }
Review Comment:
Not sure I like this default case here... I mean, if this is an exceptional
case that shouldn't ever happen, I think we should throw an Error here. Same
for the other switch-case.
##########
packages/dmn-editor/playwright.config.ts:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { defineConfig } from "@playwright/test";
+import playwirghtBaseConfig from
"@kie-tools/playwright-base/playwright.config";
+import merge from "lodash/merge";
+import { env } from "./env";
+
+const buildEnv: any = env;
+
+const customConfig = defineConfig({
+ use: {
+ baseURL: `http://localhost:${buildEnv.dmnEditor.storybook.port}`,
+ },
+ /* Run your local dev server before starting the tests */ /* Run your local
dev server before starting the tests */
Review Comment:
Duplicated comment?
##########
packages/dmn-editor/stories/useCases/empty/Empty.mdx:
##########
@@ -0,0 +1,29 @@
+{/* prettier-ignore */}
+{/*
Review Comment:
? :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
