gmunozfe commented on code in PR #3412:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3412#discussion_r1502829560
##########
api/kogito-events-core/src/main/java/org/kie/kogito/event/impl/ProcessEventDispatcher.java:
##########
@@ -74,31 +73,59 @@ public CompletableFuture<ProcessInstance<M>>
dispatch(String trigger, DataEvent<
}
return CompletableFuture.completedFuture(null);
}
+ return resolveCorrelationId(event)
+ .map(kogitoReferenceId -> asCompletable(trigger, event,
findById(kogitoReferenceId)))
+ .orElseGet(() -> {
+ // check processInstanceId
+ String processInstanceId = event.getKogitoReferenceId();
+ if (processInstanceId != null) {
+ return asCompletable(trigger, event,
findById(processInstanceId));
+ }
+ // check businessKey
+ String businessKey = event.getKogitoBusinessKey();
+ if (businessKey != null) {
+ return asCompletable(trigger, event,
findByBusinessKey(businessKey));
+ }
+ // try to start a new instance if possible
+ return CompletableFuture.supplyAsync(() ->
startNewInstance(trigger, event), executor);
+ });
+ }
- final String kogitoReferenceId = resolveCorrelationId(event);
- if (!ConversionUtils.isEmpty(kogitoReferenceId)) {
- return CompletableFuture.supplyAsync(() ->
handleMessageWithReference(trigger, event, kogitoReferenceId), executor);
- }
+ private CompletableFuture<ProcessInstance<M>> asCompletable(String
trigger, DataEvent<D> event, Optional<ProcessInstance<M>> processInstance) {
+ return CompletableFuture.supplyAsync(() -> processInstance.map(pi -> {
+ signalProcessInstance(trigger, pi.id(), event);
Review Comment:
You can add a debug trace to indicate that it's signalling here
` if (LOGGER.isDebugEnabled()) {
LOGGER.debug("sending signal from '{}'", trigger);
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
