gitgabrio commented on PR #5746: URL: https://github.com/apache/incubator-kie-drools/pull/5746#issuecomment-1965977895
> I don't think it can be ignored for the rule evaluation. If it is a boolean condition, it is a constraint in my opinion. What do you think please? Also how does it behave please for non-Boolean typed expressions? As stated in the comment, that modification on the executable model EXACTLY MIMIC what happen in the legacy one. Please look at the test, that verify the two different conditions (true/false) for both implementations. IINW drools currently does not support the nested assignment before "when" evaluation. My understanding is that (if there is an assignment inside an object): 1. drools evaluate the condition based on presence of the object itself, and possibly properties already defined for the object 2. after that, it evaluate the nested property assignment, populating it IIUC, the request would be to 1. first, evaluate the inner property assignement 2. then, evaluate the when condition I have the impression it would be quite a change, to be done at both compile and execution time, for both model implementations. This PR ensure the behaviour in the given cases is the same for both implementations, and this is required to allow migration by users. Changing the logic itself would require more effort, and I think it should be delegated to a specific ticket. @mariofusco Of course, all my previous assumptions may be wrong, feel free to correct/extend, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
