gitgabrio commented on PR #5748: URL: https://github.com/apache/incubator-kie-drools/pull/5748#issuecomment-1966660034
Many thanks @yurloc for the explanation. I've only a couple of question: 1. would it be possible to somehow document, very briefly, the reason of the modification inside the code, somewhere ? With @tkobayas, in the past, we discussed a bit that all this code is pretty hard to understand 2. there is a new test: is this relevant for the modification introduced ? If so, maybe it would be possible to add a small comment there, just to explain the relationship between the modification in the DRL6Expression.g4, and the new test My personal focus, here, is to improve the "readability" (at least in general terms) also by someone that does not work on it daily: does this make sense ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
