jordigilh commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1505079016
##########
test/e2e/workflow_test.go:
##########
@@ -198,16 +198,27 @@ var _ = Describe("Validate the persistence ", Ordered,
func() {
}
Expect(h.Status).To(Equal(upStatus), "Pod
health is not UP")
for _, c := range h.Checks {
- if c.Name == "Database connections
health check" {
-
Expect(c.Status).To(Equal(upStatus), "Pod's database connection is not UP")
- return true
+ if withPersistence {
+ if c.Name == "Database
connections health check" {
+
Expect(c.Status).To(Equal(upStatus), "Pod's database connection is not UP")
+ return true
+ }
+ } else {
+
Expect(c.Name).NotTo(Equal("Database connections health check"), "persistence
configuration found in workflow")
}
}
+ if !withPersistence {
+ return true
+ }
}
return false
- }, 12*time.Minute).Should(BeTrue())
+ }, 1).Should(BeTrue())
Review Comment:
It should not take more than 1 minute to stabilize the pod's health status.
The previous value, 12 minutes, is too long for something that should take
seconds. Worst case it would take 12 minutes for the test to fail and that I
think it's too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
