jomarko commented on code in PR #2188: URL: https://github.com/apache/incubator-kie-tools/pull/2188#discussion_r1510818655
########## packages/scesim-editor/tests/e2e/__screenshots__/Google-Chrome/scesimEditor/Rule/TestScenario/test-scenario-table-rule.png: ########## Review Comment: The values in the table seems to me somehow randomly put in. Is this more check that valid expressions for testing DRL can be put into any cell? Or put the question differently, does this SCESIM test some DRL (even mocked) file? ########## packages/scesim-editor/tests/e2e/features/keyboard/keyboard.spec.ts: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { expect, test } from "../../__fixtures__/base"; + +test.describe("Keyboard", () => { + test.describe("Navigation", () => { + test("should correctly navigate", async () => { + // enter, shift+enter, tab, shift+tab, escape + // currently not working in playwright + }); + }); + + test.describe("Arrow Key Navigation", () => { + test("should correctly navigate the page using arrow keys", async ({ stories, page }) => { + await stories.openTestScenarioTableDecision(); + await page.getByRole("cell", { name: "1" }).click(); + await page.getByRole("cell", { name: "1" }).locator("div").nth(1).click(); + await page.getByRole("cell", { name: "1" }).locator("div").nth(1).click(); + await page.getByRole("cell", { name: "1" }).locator("div").nth(1).click(); + await page.getByRole("row", { name: "1", exact: true }).click(); + await page.getByRole("row", { name: "1", exact: true }).press("ArrowRight"); + await page.getByRole("row", { name: "1", exact: true }).press("ArrowRight"); + await page.getByRole("row", { name: "1", exact: true }).press("ArrowDown"); + await page.getByRole("row", { name: "2", exact: true }).press("ArrowLeft"); + await page.getByRole("row", { name: "1", exact: true }).press("ArrowDown"); + await page.getByRole("row", { name: "2", exact: true }).press("ArrowLeft"); + await page.getByRole("row", { name: "3", exact: true }).press("ArrowUp"); + await page.getByRole("row", { name: "2", exact: true }).press("ArrowRight"); + await page.getByRole("row", { name: "2", exact: true }).press("ArrowDown"); + await page.getByRole("row", { name: "3", exact: true }).press("ArrowDown"); + await page.getByRole("row", { name: "4", exact: true }).press("Enter"); Review Comment: maybe here we have a candidate for `fixture`, lets say cells? I can imagine then to have API like: - `cells.rightCell()` - `cells.leftCell()` - `cells.upperCell()` - `cells.bottomCell()` - maybe all of above with Nth version, `cells.nthUpperCell(n)` ? - `cells.active()` , `cells.editActive()`? I do not know, just idea, sounds like operations we will use very often will cells -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
