baldimir commented on code in PR #3424:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3424#discussion_r1512308378
##########
kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionCodegen.java:
##########
@@ -134,19 +134,21 @@ private void generateAndStoreRestResources() {
List<DecisionRestResourceGenerator> rgs = new ArrayList<>(); // REST
resources
List<DMNModel> models =
resources.stream().map(DMNResource::getDmnModel).collect(Collectors.toList());
- DMNOASResult oasResult = null;
- try {
- Comparator<DMNModel> nsNameComparator =
Comparator.comparing(DMNModel::getNamespace).thenComparing(DMNModel::getName);
- List<DMNModel> orderedModels = new ArrayList<>(models);
- Collections.sort(orderedModels, nsNameComparator);
- oasResult =
DMNOASGeneratorFactory.generator(orderedModels).build();
- String jsonContent = new
ObjectMapper().writeValueAsString(oasResult.getJsonSchemaNode());
- storeFile(GeneratedFileType.STATIC_HTTP_RESOURCE,
"dmnDefinitions.json", jsonContent);
- } catch (Exception e) {
- LOGGER.error("Error while trying to generate OpenAPI specification
for the DMN models", e);
- }
+ // DMNOASResult oasResult = null;
Review Comment:
It looks to me as a leftover. So probably should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
