gitgabrio commented on code in PR #5762:
URL:
https://github.com/apache/incubator-kie-drools/pull/5762#discussion_r1512657996
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/visitor/accumulate/AccumulateVisitor.java:
##########
@@ -406,10 +414,10 @@ private boolean
parameterNeedsConvertionToMethodCallExpr(Expression accumulateFu
return accumulateFunctionParameter.isMethodCallExpr() ||
accumulateFunctionParameter.isArrayAccessExpr() ||
accumulateFunctionParameter.isFieldAccessExpr();
}
- private Optional<NewBinding> binaryExprParameter(PatternDescr basePattern,
AccumulateDescr.AccumulateFunctionCallDescr function, MethodCallExpr
functionDSL, String bindingId, String accumulateFunctionParameterStr) {
+ private Optional<NewBinding> binaryOrUnaryExprParameter(PatternDescr
basePattern, AccumulateDescr.AccumulateFunctionCallDescr function,
MethodCallExpr functionDSL, String bindingId, String
accumulateFunctionParameterStr) {
Review Comment:
HI @yesamer
Would it make sense to rename it as `bindingParameter` or similar ?
1. if, by chance, we discover that another kind of expression has to be
managed here, the method name would become awfull
2. usually, the method name express the returned object
3. IINW, nothing prevent this method to be invoked by somehting different
then a `BinaryExpr` or a `UnaryExpr` (if it is implicitily so, I think there
should be a check/guard somehow)
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
