yurloc commented on code in PR #5764:
URL:
https://github.com/apache/incubator-kie-drools/pull/5764#discussion_r1513151169
##########
drools-persistence/drools-persistence-jpa/pom.xml:
##########
@@ -76,6 +75,29 @@
</additionalClasspathElements>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.openjpa</groupId>
+ <artifactId>openjpa-maven-plugin</artifactId>
+ <version>4.0.0</version>
+ <configuration>
+ <includes>org.drools.persistence.info.WorkItemInfo,
+ org.drools.persistence.info.SessionInfo,
+ org.drools.persistence.jta.TransactionTestObject
+ </includes>
+ <addDefaultConstructor>true</addDefaultConstructor>
+ <enforcePropertyRestrictions>true</enforcePropertyRestrictions>
+ </configuration>
+ <executions>
+ <execution>
+ <id>enhancer</id>
+ <phase>process-test-classes</phase>
+ <goals>
+ <goal>test-enhance</goal>
+ </goals>
+ </execution>
Review Comment:
@mariofusco I'm a bit concerned whether this can't negatively affect the
included classes. Not sure what the enhancing does, but if it modified the
class files' byte code permanently and polluted them with some OpenJPA APIs it
would introduce a runtime dependency on it, which is bad if these drools
persistence classes are a public API that should be JPA
implementation-agnostic, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
