wmedvede commented on code in PR #416:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/416#discussion_r1514681559
##########
controllers/platform/services/services.go:
##########
@@ -265,6 +269,9 @@ func (j JobServiceHandler) GetContainerName() string {
}
func (j JobServiceHandler) GetServiceImageName(persistenceName string) string {
+ if len(cfg.GetCfg().JobsServiceImageTag) > 0 {
+ return cfg.GetCfg().JobsServiceImageTag
Review Comment:
Not sure if this is good, or at least it's not aligned to what we had. Let
me explain:
In order to get the proper jobs-service image, right now, two variables are
considered, the "persitenceName" and the "tag" to use.
For example, if no persistence is configured, "ephemeral" persistence will
be considered, and thus, the returned image will be
kogito-jobs-service-ephemeral-nightly:latest.
On the other hand, if postgresql is configured, then,
kogito-jobs-service-postgresql-nightly:latest will be used instead.
So, the image might vary depending on the persistence type we are using.
With your change, only one image JobsServiceImageTag is admitted. Is that
correct?
##########
controllers/platform/services/services.go:
##########
@@ -101,6 +102,9 @@ func (d DataIndexHandler) GetContainerName() string {
}
func (d DataIndexHandler) GetServiceImageName(persistenceName string) string {
+ if len(cfg.GetCfg().DataIndexImageTag) > 0 {
Review Comment:
same comment as for the jobs-service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
