tiagobento commented on code in PR #2189:
URL:
https://github.com/apache/incubator-kie-tools/pull/2189#discussion_r1515376734
##########
packages/dmn-editor/src/diagram/nodes/Nodes.tsx:
##########
@@ -239,20 +239,19 @@ export const InputDataNode = React.memo(
onDoubleClick={triggerEditing}
onKeyDown={triggerEditingIfEnter}
style={alternativeSvgStyle}
- className={selectedAlternativeClass}
+ className={`kie-dmn-editor--node ${selectedAlternativeClass}`}
Review Comment:
There's one `"kie-dmn-editor--node"` inside another `"kie-dmn-editor--node"`?
##########
packages/dmn-editor/env/index.js:
##########
@@ -23,14 +23,9 @@ module.exports =
composeEnv([require("@kie-tools/root-env/env")], {
vars: varsWithName({}),
get env() {
return {
- dmnEditor: {
- dev: {
- port: 3001,
- },
- },
dmnEditor: {
storybook: {
- port: 9901,
Review Comment:
Are all ports on `env/index.js` files defined as strings? I know this had
the color bug with the special characters and everything, but it's really
bugging me that this could be the only place where we need these numbers to be
defined as strings...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
