yesamer commented on PR #2010: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2010#issuecomment-1982988002
@treivize Thank you for providing this patch and for following our fixing process (opening a ticket and its related PR), we appreciate it a lot! However, the code that impacts your change will be soon moved into another repository (https://github.com/apache/incubator-kie-tools/pull/2180). Moreover, that PR [already contains a null guard ](https://github.com/apache/incubator-kie-tools/pull/2180/files#diff-c338a47660db694f8c5a8e53c2a0863ade7dba30d5e61d0a9e10d6399e4d3567R311) After the merge of that PR, the involved code will be removed from this` kogito-apps` repo. With these premises, I guess doesn't make sense to merge your PR, despite your change being correct. In any case, I invite you to double-check if the bug you spotted still occurs after the PR merge, if that is the case please feel free to open a new PR in the `kie-tools` repo. Thank you again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
