Rikkola opened a new pull request, #5775: URL: https://github.com/apache/incubator-kie-drools/pull/5775
https://github.com/apache/incubator-kie-drools/issues/5774 Some thoughts, questions and notes: - This PR does not make YaRD a Kie Resource, should it? - Currently only "scripting" language supported is JShell. It is plain Java so not that "scripty", should we use MVEL or even FEEL? - Reason for treblereel YAML Mapper is the need to use the same YaRD API on the client side. This mapper works on both Java and JavaScript/J2CL - For Decision Tables. Hit policies FIRST, COLLECT and ANY are implemented. Each one of them does one run on the data and returns another set of data. Compared to the other Drools dtables the behaviour is different ( but not wrong ). Later we might want to add table modes that allow editing the inputs and repassing them to the table, like the older Drools dtables do. - Inputs can have a schema as a type. However that is not tested, but using an object as an input and accessing the fields might still work, who knows. <details> <summary> How to replicate CI configuration locally? </summary> Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it. </details> <details> <summary> How to retest this PR or trigger a specific build: </summary> - for <b>pull request and downstream checks</b> - Push a new commit to the PR. An empty commit would be enough. - for a <b>full downstream build</b> - for <b>github actions</b> job: add the label `run_fdb` - for <b>Jenkins PR check only</b> - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
