martinweiler commented on code in PR #3403:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3403#discussion_r1516856650
##########
jbpm/process-serialization-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriter.java:
##########
@@ -55,56 +79,45 @@
import org.jbpm.workflow.instance.node.SubProcessNodeInstance;
import org.jbpm.workflow.instance.node.TimerNodeInstance;
import org.jbpm.workflow.instance.node.WorkItemNodeInstance;
+import org.kie.api.definition.process.WorkflowElementIdentifier;
import org.kie.api.runtime.process.NodeInstance;
import org.kie.kogito.internal.process.runtime.KogitoNodeInstance;
+import org.kie.kogito.internal.process.runtime.KogitoProcessRuntime;
import org.kie.kogito.internal.process.runtime.KogitoWorkItem;
+import org.kie.kogito.process.impl.AbstractProcess;
import org.kie.kogito.process.workitem.Attachment;
import org.kie.kogito.process.workitem.Comment;
import org.kie.kogito.process.workitem.HumanTaskWorkItem;
-import org.kie.kogito.serialization.process.MarshallerWriterContext;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.AsyncEventNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.CompositeContextNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.DynamicNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.EventNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.EventSubProcessNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.ForEachNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.JoinNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.JoinNodeInstanceContent.JoinTrigger;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.LambdaSubProcessNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.MilestoneNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.RuleSetNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.StateNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.SubProcessNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.TimerNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoNodeInstanceContentsProtobuf.WorkItemNodeInstanceContent;
-import
org.kie.kogito.serialization.process.protobuf.KogitoProcessInstanceProtobuf;
-import org.kie.kogito.serialization.process.protobuf.KogitoTypesProtobuf;
-import
org.kie.kogito.serialization.process.protobuf.KogitoTypesProtobuf.WorkflowContext;
-import org.kie.kogito.serialization.process.protobuf.KogitoWorkItemsProtobuf;
-import
org.kie.kogito.serialization.process.protobuf.KogitoWorkItemsProtobuf.HumanTaskWorkItemData;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import com.google.protobuf.Any;
import com.google.protobuf.util.JsonFormat;
-import static
org.kie.kogito.serialization.process.MarshallerContextName.MARSHALLER_FORMAT;
-import static
org.kie.kogito.serialization.process.MarshallerContextName.MARSHALLER_FORMAT_JSON;
-import static
org.kie.kogito.serialization.process.protobuf.ProtobufTypeRegistryFactory.protobufTypeRegistryFactoryInstance;
+import static
org.jbpm.flow.serialization.MarshallerContextName.MARSHALLER_FORMAT;
+import static
org.jbpm.flow.serialization.MarshallerContextName.MARSHALLER_FORMAT_JSON;
+import static
org.jbpm.flow.serialization.protobuf.ProtobufTypeRegistryFactory.protobufTypeRegistryFactoryInstance;
public class ProtobufProcessInstanceWriter {
-
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ProtobufProcessInstanceWriter.class);
private MarshallerWriterContext context;
private ProtobufVariableWriter varWriter;
+ private ProcessInstanceMarshallerListener[] listeners;
public ProtobufProcessInstanceWriter(MarshallerWriterContext context) {
this.context = context;
this.varWriter = new ProtobufVariableWriter(context);
+ this.listeners =
context.get(MarshallerContextName.MARSHALLER_INSTANCE_LISTENER);
}
public void writeProcessInstance(WorkflowProcessInstanceImpl workFlow,
OutputStream os) throws IOException {
+ KogitoProcessRuntime runtime = ((AbstractProcess<?>)
context.get(MarshallerContextName.MARSHALLER_PROCESS)).getProcessRuntime();
+ Arrays.stream(listeners).forEach(e -> e.beforeMarshallProcess(runtime,
workFlow));
KogitoProcessInstanceProtobuf.ProcessInstance.Builder instance =
KogitoProcessInstanceProtobuf.ProcessInstance.newBuilder()
.setId(workFlow.getStringId())
.setProcessId(workFlow.getProcessId())
+ .setProcessVersion(workFlow.getProcessVersion())
Review Comment:
Test failures in `addons/common/persistence/infinispan`:
```
Caused by: java.lang.NullPointerException
at
org.jbpm.flow.serialization.protobuf.KogitoProcessInstanceProtobuf$ProcessInstance$Builder.setProcessVersion(KogitoProcessInstanceProtobuf.java:2675)
at
org.jbpm.flow.serialization.impl.ProtobufProcessInstanceWriter.writeProcessInstance(ProtobufProcessInstanceWriter.java:120)
at
org.jbpm.flow.serialization.impl.ProtobufProcessInstanceMarshaller.writeProcessInstance(ProtobufProcessInstanceMarshaller.java:42)
at
org.jbpm.flow.serialization.ProcessInstanceMarshallerService.marshallProcessInstance(ProcessInstanceMarshallerService.java:134)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
