gitgabrio commented on code in PR #5765:
URL:
https://github.com/apache/incubator-kie-drools/pull/5765#discussion_r1517548114
##########
drools-model/drools-codegen-common/src/main/java/org/drools/codegen/common/AppPaths.java:
##########
@@ -47,6 +47,7 @@ public static AppPaths.BuildTool findBuildTool() {
private final boolean isJar;
private final BuildTool bt;
private final Path resourcesPath;
+ private final Path generatedResourcesPath;
Review Comment:
I did not want to make a too invasive modification, but IMO the point is
that, regardless of actual path, `resourcesPath` and `generatedResourcesPath`
are exactly the same thing - i.e. directories that contains the resources.
So, in future I think they must be unified, instead of being two different
objects (this is what actually happen, behind the scenes)
I noticed that `getResourceFiles` method, and honestly it is just a leftover
that I've just fixed.
With all that in place, I think it is clearer that the twos are actually the
same thing.
Does this make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
