gitgabrio commented on PR #5779: URL: https://github.com/apache/incubator-kie-drools/pull/5779#issuecomment-1991728841
Thanks @yurloc , but I just modified this class and, for the moment being, I think it is better to keep it as it is. Some side notes: 1. some of the refactoring (mostly, the static methods) are aimed at improve testability (this class has never been tested before), even if currently I had no time to extend them 2. `Path.of` and `path.resolve` have completely different semantics 3. I saw that the `isJar` boolean is always true, but for the moment being I preferred to kept it in the static method (see above about tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
