fjtirado commented on code in PR #3441:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3441#discussion_r1526039279
##########
addons/common/persistence/jdbc/src/main/java/org/kie/kogito/persistence/jdbc/GenericRepository.java:
##########
@@ -34,32 +34,35 @@
import javax.sql.DataSource;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
public class GenericRepository extends Repository {
private static final String PAYLOAD = "payload";
private static final String VERSION = "version";
- private static final Logger LOGGER =
LoggerFactory.getLogger(GenericRepository.class);
-
private final DataSource dataSource;
public GenericRepository(DataSource dataSource) {
this.dataSource = dataSource;
}
@Override
- void insertInternal(String processId, String processVersion, UUID id,
byte[] payload) {
+ void insertInternal(String processId, String processVersion, UUID id,
byte[] payload, String businessKey) {
Review Comment:
The code is relying in on cascade, so deleting the process instance also
delete the business key entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]