gmunozfe commented on code in PR #585:
URL: 
https://github.com/apache/incubator-kie-kogito-docs/pull/585#discussion_r1528048528


##########
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc:
##########
@@ -0,0 +1,104 @@
+= Workflow embedded execution in Java 
+
+This guide show cases how to execute a link:{spec_doc_url}[CNCF Serverless 
Workflow] definition using a standard java virtual machine and a small set of 
Maven dependencies. Therefore, it is assumed you are fluent both in Java and 
Maven. 
+The workflow definition to be executed can be read from a .json or .yaml file 
or programatically defined using the {product_name} fluent API. 
+
+[[embedded-file-quick-start]]
+== Hello world (using existing definition file)
+
+First step is to setup an empty Maven project with the following dependency. 
+
+[source,xml]
+----
+<dependency>
+  <groupId>org.kie.kogito</groupId>
+  <artifactId>kogito-serverless-workflow-executor-core</artifactId>
+  <version>RELEASE</version>
+</dependency>
+----
+
+Also, you might optionally add `simple logger for java` dependency to avoid 
using `system.out.println`

Review Comment:
   ```suggestion
   Also, you might optionally add `simple logger for java` dependency to avoid 
using `System.out.println`
   ```



##########
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc:
##########
@@ -0,0 +1,104 @@
+= Workflow embedded execution in Java 
+
+This guide show cases how to execute a link:{spec_doc_url}[CNCF Serverless 
Workflow] definition using a standard java virtual machine and a small set of 
Maven dependencies. Therefore, it is assumed you are fluent both in Java and 
Maven. 
+The workflow definition to be executed can be read from a .json or .yaml file 
or programatically defined using the {product_name} fluent API. 
+
+[[embedded-file-quick-start]]
+== Hello world (using existing definition file)
+
+First step is to setup an empty Maven project with the following dependency. 
+
+[source,xml]
+----
+<dependency>
+  <groupId>org.kie.kogito</groupId>
+  <artifactId>kogito-serverless-workflow-executor-core</artifactId>
+  <version>RELEASE</version>
+</dependency>
+----
+
+Also, you might optionally add `simple logger for java` dependency to avoid 
using `system.out.println`
+
+[source,xml]
+----
+ <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>1.7.36</version>
+  </dependency>
+----
+
+Lets assume you already have a workflow definition written in a JSON file in 
your project root. For example, 
link:{kogito_sw_examples_url}/serverless-workflow-hello-world/src/main/resources/hello.sw.json[Hello
 World] definition. In order to execute it, you need to write the following 
main java class (standard imports and java package declaration are 
intentionally skipped for brevity)

Review Comment:
   ```suggestion
   Let's assume you already have a workflow definition written in a JSON file 
in your project root. For example, 
link:{kogito_sw_examples_url}/serverless-workflow-hello-world/src/main/resources/hello.sw.json[Hello
 World] definition. To execute it, you need to write the following main java 
class (standard imports and java package declaration are intentionally skipped 
for brevity)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to