mariofusco commented on code in PR #5788:
URL:
https://github.com/apache/incubator-kie-drools/pull/5788#discussion_r1528232596
##########
drools-core/src/main/java/org/drools/core/reteoo/ReteooBuilder.java:
##########
@@ -201,9 +201,9 @@ public void removeTerminalNode(RuleRemovalContext context,
TerminalNode tn, Coll
private Collection<BaseNode> removeNodes(AbstractTerminalNode
terminalNode, Collection<InternalWorkingMemory> wms, RuleRemovalContext
context) {
Map<Integer, BaseNode> stillInUse = new HashMap<>();
- Collection<ObjectSource> alphas = new HashSet<>();
+ Collection<ObjectSource> alphas = new ArrayList<>();
Review Comment:
We used a Set here to be sure of not traversing and processing the same
nodes more than once, are you sure that there are no longer duplication and it
is now save to use a List instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
