yesamer commented on code in PR #2017:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2017#discussion_r1528861562
##########
jitexecutor/jitexecutor-dmn/src/test/java/org/kie/kogito/jitexecutor/dmn/DMN15Test.java:
##########
@@ -1,7 +1,7 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
+ * distributed with this work for additional .debugrmation
Review Comment:
@gitgabrio Typo
##########
jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/api/DMNValidationResource.java:
##########
@@ -47,13 +47,21 @@
@Path("jitdmn/validate")
public class DMNValidationResource {
+ private static final Logger LOGGER =
Logger.getLogger(DMNValidationResource.class);
+
+ static final String LINEBREAK = "******\n";
+
// trick for resolver/implementation for NI
- static final DMNValidator validator =
DMNValidatorFactory.newValidator(Arrays.asList(new ExtendedDMNProfile()));
+ static final DMNValidator validator =
DMNValidatorFactory.newValidator(List.of(new ExtendedDMNProfile()));
Review Comment:
@gitgabrio Is this intended? Mutable to Unmutable collection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
