yurloc commented on code in PR #5793:
URL:
https://github.com/apache/incubator-kie-drools/pull/5793#discussion_r1529972018
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -512,3 +512,37 @@ drlVariableInitializer
drlArrayInitializer
: LBRACE (drlVariableInitializer (COMMA drlVariableInitializer)* (COMMA)?
)? RBRACE
;
+
+/* extending JavaParser block */
+drlBlock
Review Comment:
Quick thought: we keep overriding the JavaParser rules again and again...
that adds a lot of duplicate code. Is it possible to remove the original rule
from JavaParser every time we override one? Simply remove JavaParser rules that
are no longer being used since we use the overriding rules.
We could end up with a pretty minimal JavaParser at the end or perhaps get
rid of it completely.
Or is this impossible because we still need to parse plain old Java code in
the RHS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
