tkobayas commented on PR #5794: URL: https://github.com/apache/incubator-kie-drools/pull/5794#issuecomment-2006669771
@gitgabrio Thank you for the suggestion. `startCharacter` and `endCharacter` are Descr's properties, so populating them is not a workaround, rather a right thing to do from the parser point of view. Having said that, - This PR is okay as-is and - It's great to refactor/improve the `ChangeSetBuilder.diffDescrs` method, so could you file it as a separate issue? Does it make sense? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
